Open
Conversation
Contributor
|
also added some lib package dep |
Member
|
You need to read the contributing and submission guidelines regarding commit and PR formatting. And you must set yourself as the maintainer, and provide run-testing details. |
Member
|
You need to fix your commit message. |
This adds the vzlogger package to the OpenWrt packages feed. It enables building and installing vzlogger on supported targets. Signed-off-by: Andy Voigt <a.voigt@mailbox.org>
Member
|
Both packages have tagged versions. Why aren't you using those? And it makes sense to split them into two separate commits. The commit message should describe what the package does and not just:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @Andy-Voigt
Description:
This package provides vzlogger. A lightweight, flexible meter data logging daemon that is part of the Volkszähler project. It is designed to collect measurement data from various utility meters such as electricity, gas, water, and heat meters. The collected data is transmit to a central server over mqtt or written directly into a database.
🧪 Run Testing Details
✅ Formalities